theforeman / foreman_fog_proxmox

Foreman plugin to add Proxmox compute resource based on fog-proxmox gem
GNU General Public License v3.0
106 stars 33 forks source link

Taking over incomplete volume parameters #361

Open libc225so opened 1 month ago

libc225so commented 1 month ago

Describe the bug When a new VM is to be created with a request for disks that are not in the ComputeProfile but simply added for example like this ( through hammer ) with: --volume='size=10GB' --volume='size=20GB' the disks do not show up properly in the json.

They show up like this: "volumes_attributes"=>{ "0"=>{"storage_type"=>"hard_disk", "storage"=>"local-lvm", "controller"=>"virtio", "device"=>"0", "cache"=>"none", "size"=>"19GB", "id"=>"virtio0"}, "1"=>{"size"=>"10GB"}, "2"=>{"size"=>"20GB"}},

To Reproduce 1) add new vm with hammer like this: hammer host create ....... --volume='size=10GB' --volume='size=20GB'

2) check and see how much disks the created host has in proxmox ( only the ones defined in the ComputeProfile) will show and the extra added with the --volume lines wont be visible

Expected behavior In no2 from the reproducing step, the manual added disks should show as well in the interface

Desktop (please complete the following information):

Smartphone (please complete the following information): Did not check it there