search

theforeman / foreman_rh_cloud

a plugin to Foreman that generates and uploads reports to the Red Hat cloud
GNU General Public License v3.0
6 stars 32 forks source link

don't pin cosmiconfig-typescript-loader anymore #909

Closed evgeni closed 1 month ago

evgeni commented 1 month ago

We pinned that in cc0511a7 to fix tests, but do not depend on it ourself. Let's unpin and see if tests are green again.

evgeni commented 1 month ago

I think it's fine since d8fb53e3f83d44b5f0a3e4e0fe1d6f673d9a09fa as we stopped using pnpm and #831 (where this pin was added) indicates it was an issue with pnpm?

chris1984 commented 1 month ago

I think it's fine since d8fb53e as we stopped using pnpm and #831 (where this pin was added) indicates it was an issue with pnpm?

Do we need this in the v10 branch as well?

evgeni commented 1 month ago

I think it's fine since d8fb53e as we stopped using pnpm and #831 (where this pin was added) indicates it was an issue with pnpm?

Do we need this in the v10 branch as well?

Nah, we only do automatic package bumps in nightly, and that's where I noticed things go wrong in automation.

chris1984 commented 1 month ago

I think it's fine since d8fb53e as we stopped using pnpm and #831 (where this pin was added) indicates it was an issue with pnpm?

Do we need this in the v10 branch as well?

Nah, we only do automatic package bumps in nightly, and that's where I noticed things go wrong in automation.

Send it