theforeman / foreman_rh_cloud

a plugin to Foreman that generates and uploads reports to the Red Hat cloud
GNU General Public License v3.0
6 stars 32 forks source link

Fixes #919 - isNotRhelHost regex too restrictive #920

Closed Thorben-D closed 2 weeks ago

Thorben-D commented 3 weeks ago

This PR changes the regex used in the isNotRhelHost function, which was introduced in #911. The regex now accepts variations of RedHat, RHEL and RHCOS as valid.

Additionally, the wrong parameter was passed to the function in InsightsTotalRiskChartWrapper.

CC @chris1984

Thorben-D commented 3 weeks ago

@chris1984 Sorry, it was a public holiday and I just managed to check my mail this evening. I made some changes to the JS code, which fixed the pipeline!

chris1984 commented 2 weeks ago

@Thorben-D Awesome, thanks for the fix :) Will get it merged