Define actions as interfaces

[spoenemann]

Just a thought:

Actions are meant to be plain JSON data structures that can be transferred between client and server. Currently they are implemented with classes, and their properties are all passed via constructor.

export class MoveAction implements Action {
    kind = MoveCommand.KIND

    constructor(public readonly moves: ElementMove[],
                public readonly animate: boolean = true) {
    }
}

const action = new MoveAction([{ elementId: 'foo', toPosition: { x: 10, y: 20 } }], true)

An alternative would be to define actions as interfaces.

export interface MoveAction extends Action {
    kind: 'move'
    moves: ElementMove[]
    animate: boolean
}

const action = <MoveAction>{
    kind: 'move',
    moves: [{ elementId: 'foo', toPosition: { x: 10, y: 20 } }],
    animate: true
}

This would prevent using the action classes as runtime values, which can lead to mistakes such as using instanceof on an action.