search

theia-ide / theia-apps

Theia applications examples - docker images, desktop apps, packagings
Apache License 2.0
1.04k stars 345 forks source link

Builds failing #486

Closed rburchill closed 3 years ago

rburchill commented 3 years ago

The yarn build command is failing for me locally and in GH Actions. See GH Actions for more info:

https://github.com/theia-ide/theia-apps/runs/3177253292?check_suite_focus=true#step:6:443

I think the relevant error is:

ERROR in bundle.js from Terser
Unexpected token: name (then) [webpack://./node_modules/es6-promise/dist/lib/es6-promise/then.js:5,24][bundle.js:244505,10]

I don't know enough yarn/webpack to intelligently debug this. Can someone advise on the best way to get back to a known good build?

MattImmersive commented 3 years ago

Also having the same problem - was building fine yesterday morning. We've managed to get it to build by messing with the dependencies but this just causes other issues with the app.

rburchill commented 3 years ago

The change in the open PR fixes this for me: https://github.com/theia-ide/theia-apps/pull/487/files

Thank you @vince-fugnitto!

marcdumais-work commented 3 years ago

Thanks for the report. This seems caused ultimately by a webpack issue, that we inherit from upstream Theia, using it as a dependency. There's a temporary work-around that was merged and published upstream, that should clear it, until the root issue is fixed.

vince-fugnitto commented 3 years ago

@rburchill thank you for reporting the issue, the fix has been merged upstream, and the builds should now be passing. The issue is with a dependency of one of our dependencies (webpack > webpack-sources), and we will wait for them to provide a fix before we update the version range again :+1: