thelastpickle / cassandra-medusa

Apache Cassandra Backup and Restore Tool
Apache License 2.0
266 stars 143 forks source link

Prevent gRRPC's BackupStatus from canceling pending futures #745

Closed rzvoncek closed 6 months ago

rzvoncek commented 7 months ago

Fixes #742.

Prior to this patch, I could even reproduce the exception from the issue in the integration tests:

[2024-04-11 13:17:02,362] INFO: Registered backup id grpc_backup_23
[2024-04-11 13:17:02,363] INFO: Recording async backup information.
[2024-04-11 13:17:02,363] ERROR: Exception in callback record_backup_info(<Future cancelled>) at /Users/zvo/github/cassandra-medusa/medusa/service/grpc/server.py:346
handle: <Handle record_backup_info(<Future cancelled>) at /Users/zvo/github/cassandra-medusa/medusa/service/grpc/server.py:346>
Traceback (most recent call last):
  File "/Users/zvo/anaconda3/lib/python3.11/asyncio/events.py", line 80, in _run
    self._context.run(self._callback, *self._args)
  File "/Users/zvo/github/cassandra-medusa/medusa/service/grpc/server.py", line 349, in record_backup_info
    if future.exception():
       ^^^^^^^^^^^^^^^^^^
asyncio.exceptions.CancelledError: Removal of backup requested. Cancelling backup Name: grpc_backup_23 with done state: False
smutel commented 7 months ago

Hello,

I have the same issue. Do you have any workaround to suggest me ? The backups seems completely hanged ...

Thanks.

sonarcloud[bot] commented 6 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud