thelovelab / fishpond

Differential expression and allelic analysis, nonparametric statistics
https://thelovelab.github.io/fishpond
27 stars 9 forks source link

now ships with enough example cells/genes to pass velociraptor test #12

Closed Varix closed 2 years ago

Varix commented 2 years ago

This SHOULD have taken 30 minutes but I ended up spending all day on it , I can't believe its 7:03pm right now. One the plus side I am now an expert in Matrix Market format as debugging the mtx and looking various outputs from writeExampleFryDat() led me to the OS specific culprit. Huge thanks to @k3yavi who helped me talk it out and took a gander at the mtx that helped rule out it being any error in my code and something else eventually.

Long story short, added 1 cell and 2 genes , to create enough data points in the shipped exampleData so that non-linear curve fitting doesn't fail as part of the pre-processing of the sce object in velocity tutorials.

fishpond now works out of the box as an entry point for alevin-fry processed data into R for velocity analysis by velociraptor , also thanks to @DongzeHE for his help with fryLoad() and implementing my changes in a robust way that future proofs the process for supporting other packages in the future.