search

themagickoala / lexical-remark

This package contains Markdown helpers and functionality for Lexical using remark-parse.
MIT License
18 stars 3 forks source link

Suggestion: Use $ naming conventions #2

Closed Bunkerbewohner closed 1 year ago

Bunkerbewohner commented 1 year ago

Hi!

I was wondering whether it would make sense to use the $ prefix for createRemarkImport and exportLexicalToMarkdown, since internally they use $getRoot, and to signal that they should only be used within methods like the EditorState's read or Editor's update.

What do you think?

themagickoala commented 1 year ago

I think that's probably a good idea. I'll probably do it as a non-breaking change and deprecate the non-prefixed versions.

themagickoala commented 1 year ago

Resolved in v0.0.27