Add reactivity to update chart options when options change

bmanth60 commented 3 weeks ago

Closes #1477

📑 Description

This PR adds reactivity from the props to run the Apex charts update method

Status

[x] Not Completed
[ ] Completed

✅ Checks

[X] My pull request adheres to the code style of this project
[X] My code requires changes to the documentation
[ ] I have updated the documentation as required
[ ] I have checked the page with https://validator.unl.edu/
[ ] All the tests have passed
[X] My pull request is based on the latest commit (not the npm version).

ℹ Additional Information

Summary by CodeRabbit

New Features
- Enhanced the chart component to dynamically update its options when the configuration changes, improving user experience with real-time updates.
Bug Fixes
- Ensured proper cleanup of the chart instance to prevent memory leaks when the component is unmounted.

vercel[bot] commented 3 weeks ago

@bmanth60 is attempting to deploy a commit to the Themesberg Team on Vercel.

A member of the Team first needs to authorize it.

coderabbitai[bot] commented 3 weeks ago

Walkthrough

The changes in this pull request enhance the Chart.svelte component by introducing a reactivity feature for the options property. A reactive statement is added to update the chart's configuration dynamically whenever the options prop changes. The overall structure of the component remains unchanged, with the initChart function continuing to manage chart initialization and lifecycle management. This ensures that the chart reflects updates to its options without introducing significant alterations to existing logic.

Changes

File	Change Summary
src/lib/charts/Chart.svelte	Added a reactive statement to update chart options dynamically when `options` prop changes.

Assessment against linked issues

Objective	Addressed	Explanation
Update chart options dynamically (Issue #1477)	✅

Possibly related PRs

#1399: This PR modifies the Chart.svelte component to export the chart instance, which is related to the reactivity feature introduced in the main PR that updates the chart options dynamically.
#1404: This PR changes how the chart's data series is updated, moving from updateOptions to updateSeries, which is relevant to the reactivity improvements made in the main PR regarding the handling of the options property.

🐇 In the garden where options bloom,
A chart now dances, dispelling gloom.
With every change, it springs to life,
Reacting swiftly, avoiding strife.
Hops of joy in every update,
A chart that thrives, oh, isn’t it great! 🌼📊

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

🪧 Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

bmanth60 commented 3 weeks ago

I may be wrong here, since you would expect this action to handle this already? https://github.com/themesberg/flowbite-svelte/blob/main/src/lib/charts/Chart.svelte#L29 arguably, the markup is not updating

vercel[bot] commented 3 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
flowbite-svelte	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 31, 2024 10:30am

bmanth60 commented 3 weeks ago

Since https://github.com/themesberg/flowbite-svelte/commit/50c84cff293a190a57021bb76b0b7723b4c80768 solves this issue, I am going to close it

themesberg / flowbite-svelte