themix-project / oomox-gtk-theme

Oomox-gtk-theme is a fork of Numix-gtk-theme with slightly different visual design choices and more customization capabilities. It can be used in Themix/Oomox app.
https://github.com/themix-project/oomox
GNU General Public License v3.0
42 stars 8 forks source link

[BUG][QUESTION] Oomox-theme header inconsistency across older GTK3/GTK2 apps #66

Closed libRh closed 1 month ago

libRh commented 4 years ago

Some older apps uses a "menuebar" (File, Edit, ..) as header. This header does not change color like the header of gnome apps (nautilus, ..). If a "gnome-app" like nautilus is focused, it changes the header color from "BG=" to "HDR_BG=". This does not apply to inkscape or other apps using a "menuebar", in this case unfocused and focused stays at "HDR_BG=" and wont change back to "BG=" if unfocused.

"BG=" in .config/oomox/colors/theme "HDR_BG=" in .config/oomox/colors/theme

I made 2 screenshots to show the behavior. Does someone know how I can change this? (manually or did I a mistake?) correct incorrect

my omox-theme

ACCENT_BG=A3BE8C ARC_TRANSPARENCY=True ARC_WIDGET_BORDER_COLOR=3B4252 BASE16_GENERATE_DARK=False BASE16_INVERT_TERMINAL=False BASE16_MILD_TERMINAL=False BG=2E3440 BTN_BG=2E3440 BTN_FG=D8DEE9 BTN_OUTLINE_OFFSET=-3 BTN_OUTLINE_WIDTH=1 CARET1_FG=A3BE8C CARET2_FG=A3BE8C CARET_SIZE=0.04 CINNAMON_OPACITY=0.8 FG=D8DEE9 GRADIENT=0.0 GTK3_GENERATE_DARK=False HDR_BG=3B4252 HDR_BTN_BG=2E3440 HDR_BTN_FG=D8DEE9 HDR_FG=D8DEE9 ICONS_ARCHDROID=A3BE8C ICONS_DARK=2E3440 ICONS_LIGHT=A3BE8C ICONS_LIGHT_FOLDER=A3BE8C ICONS_MEDIUM=A3BE8C ICONS_NUMIX_STYLE=0 ICONS_STYLE=papirus_icons ICONS_SYMBOLIC_ACTION=D8DEE9 ICONS_SYMBOLIC_PANEL=D8DEE9 MATERIA_PANEL_OPACITY=0.8 MATERIA_SELECTION_OPACITY=1.0 MATERIA_STYLE_COMPACT=True MENU_BG=3B4252 MENU_FG=D8DEE9 NAME=nord OUTLINE_WIDTH=1 ROUNDNESS=0 SEL_BG=A3BE8C SEL_FG=2E3440 SPACING=3 SPOTIFY_PROTO_BG=2E3440 SPOTIFY_PROTO_FG=D8DEE9 SPOTIFY_PROTO_SEL=A3BE8C SURUPLUS_GRADIENT1=A3BE8C SURUPLUS_GRADIENT2=D8DEE9 SURUPLUS_GRADIENT_ENABLED=False TERMINAL_ACCENT_COLOR=ebcb8b TERMINAL_BACKGROUND=2E3440 TERMINAL_BASE_TEMPLATE=monovedek TERMINAL_COLOR0=3B4252 TERMINAL_COLOR1=BF616A TERMINAL_COLOR10=A3BE8C TERMINAL_COLOR11=EBCB8B TERMINAL_COLOR12=81A1C1 TERMINAL_COLOR13=B48EAD TERMINAL_COLOR14=8FBCBB TERMINAL_COLOR15=ECEFF4 TERMINAL_COLOR2=A3BE8C TERMINAL_COLOR3=EBCB8B TERMINAL_COLOR4=81A1C1 TERMINAL_COLOR5=B48EAD TERMINAL_COLOR6=88C0D0 TERMINAL_COLOR7=E5E9F0 TERMINAL_COLOR8=4C566A TERMINAL_COLOR9=BF616A TERMINAL_FOREGROUND=D8DEE9 TERMINAL_THEME_ACCURACY=128 TERMINAL_THEME_AUTO_BGFG=True TERMINAL_THEME_EXTEND_PALETTE=False TERMINAL_THEME_MODE=manual THEME_STYLE=oomox TXT_BG=2E3440 TXT_FG=D8DEE9 UNITY_DEFAULT_LAUNCHER_STYLE=False WM_BORDER_FOCUS=3B4252 WM_BORDER_UNFOCUS=2E3440

actionless commented 4 years ago

@smurphos is it the same as https://github.com/themix-project/oomox-gtk-theme/issues/18 ?

smurphos commented 4 years ago

Hi, I don't think so, I understand this request is to have the menu bar color follow follow the titlebar in reflecting the focus state of the window, rather that not change the titlebar color?

I'm away from home and my PC at the moment but will take a look when I am back. Hopefully Sunday.

libRh commented 4 years ago

@smurphos is it the same as #18 ?

Its actually the other way around. I personally like the focused/unfcoused behavior of GTK3 themes. Sadly, there is now Menu-bar in newer "Gnome Apps", so I guess they haven't thought about consistency across older GTK3 and GTK2 apps with the mentioned "old" Menu-bar. The Menu-bar got replaced by this called "header", which should behave identically to the Menubar imho. So It seems logical the the focused/unfcoused behavior should also change from focused/unfcoused for these legacy apps using a Menubar.

Hi, I don't think so, I understand this request is to have the menu bar color follow follow the titlebar in reflecting the focus state of the window, rather that not change the titlebar color?

+1 exactly, the Menu-bar should also change color. Its even more inconsistent because the Title-bar changes color (title(app name: eg. Leafpad), minimize, maximize, close), but not the Menu-bar. The new header is just an fusion of a reduced and Menu-bar and a Title-bar. So the old Menu-bar and old Title-bar should behave identical to the "new" Header-bar.

I'm away from home and my PC at the moment but will take a look when I am back. Hopefully Sunday.

That would be very nice, I have tried to look at some script, but I could find a solution.

Be aware, this is just my opinion and if someone could prove me wrong or tell me its not possible to implement I am okay with it. I am also not a native english speaker, therefore if something seems wrong or not understandable, tell me!

libRh commented 4 years ago

Are there any news on this? I rad #18 but this only cover the new "header" not the old mentioned by me above.

smurphos commented 4 years ago

Still on my to do list.....

On Sat, 16 Nov 2019 at 08:30, GitHubRepositoryX notifications@github.com wrote:

Are there any new on this? I rad [(https://github.com//issues/18 https://github.com/themix-project/oomox-gtk-theme/issues/18#issuecomment-390231547], but this only cover the new "header" not the old mentioned by me above.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/themix-project/oomox-gtk-theme/issues/66?email_source=notifications&email_token=AG5MMTOMZSD5EKEI4HZ6IILQT6VTZA5CNFSM4I6WODL2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEHMQAA#issuecomment-554616832, or unsubscribe https://github.com/notifications/unsubscribe-auth/AG5MMTJE7FPTWUHKWN3SE7LQT6VTZANCNFSM4I6WODLQ .

nana-4 commented 4 years ago

GTK3 theming supports unfocused state, so you can change the menubar color when window's inactive.

menubar:backdrop { background-color: %BG%; }

However, as far as I know GTK2 theming doesn't support unfocused state. Inkscape, shown as an example in OP, is a GTK2 app, so I believe you can't change its menubar color when window's inactive, unless it's ported to GTK3.

actionless commented 4 years ago

@nana-4 according to https://github.com/themix-project/oomox-gtk-theme/issues/45 i recommend to not care much about gtk2 theme variant anymore