themix-project / oomox-gtk-theme

Oomox-gtk-theme is a fork of Numix-gtk-theme with slightly different visual design choices and more customization capabilities. It can be used in Themix/Oomox app.
https://github.com/themix-project/oomox
GNU General Public License v3.0
42 stars 8 forks source link

Error: argument `$amount` of `transparentize($color, $amount)` must be a number #93

Closed 333voidGirl closed 1 month ago

333voidGirl commented 1 month ago

Cannot figure this out and can't seem to find a similar issue so I'm posting here. Changing even a single color from a premade theme (or making a whole new one) results in the same error on export and a failed transparency when right-clicking on GUI applications like Firefox. Exporting a premade theme (LCARS, arc-dark, etc.) works fine and results in no errors reported, but again changing even a single color from the themix-gui causes this error. I'm using the version of oomox/themix-gui from the AUR (https://aur.archlinux.org/packages/themix-full-git).

Below is the whole output and error (with some manual edits as to not ping anyone and so on). Sorry I couldn't put it in a code block, the way its formatted is fighting against how Github formats code blocks. I genuinely cannot fix it even by manually editing the text and I'm too frustrated to keep trying to fix it.

Building theme at /home/n1l/.themes/oomox-333voidmachineV2

make clean_gtk3 make clean_gtk320 make[1]: Entering directory '/home/n1l/.themes/oomox-333voidmachineV2' make[1]: Entering directory '/home/n1l/.themes/oomox-333voidmachineV2' rm -rf "gtk-3.0/dist" rm -rf "gtk-3.20/dist" rm -f "gtk-3.20/gtk.gresource" rm -f "gtk-3.0/gtk.gresource" make[1]: Leaving directory '/home/n1l/.themes/oomox-333voidmachineV2' make[1]: Leaving directory '/home/n1l/.themes/oomox-333voidmachineV2' make gresource_gtk3 make gresource_gtk320 make[1]: Entering directory '/home/n1l/.themes/oomox-333voidmachineV2' mkdir -p "gtk-3.0/dist" make[1]: Entering directory '/home/n1l/.themes/oomox-333voidmachineV2' mkdir -p "gtk-3.20/dist" sassc -I "gtk-3.20/scss" "gtk-3.20/scss/gtk.scss" "gtk-3.20/dist/gtk.css" sassc -I "gtk-3.0/scss" "gtk-3.0/scss/gtk.scss" "gtk-3.0/dist/gtk.css" Error: argument $amount of transparentize($color, $amount) must be a number on line 141:17 of gtk-3.20/scss/_functions.scss, in function transparentize from line 141:17 of gtk-3.20/scss/_functions.scss, in function _text_shadow_color from line 25:23 of gtk-3.20/scss/widgets/_button.scss, in mixin (@)content from line 7:9 of gtk-3.20/scss/_functions.scss, in mixin exports from line 9:10 of gtk-3.20/scss/widgets/_button.scss from line 7:9 of gtk-3.20/scss/_widgets.scss from line 3:9 of gtk-3.20/scss/gtk.scss (@)return transparentize($white, 1 - $_lbg / ($_lbg * 1.3));

-- make[1]: [Makefile:57: gtk-3.20/dist/gtk.css] Error 65 make[1]: Leaving directory '/home/n1l/.themes/oomox-333voidmachineV2' make: [Makefile:82: gtk320] Error 2 make: *** Waiting for unfinished jobs.... cp "gtk-3.0/dist/gtk.css" "gtk-3.0/dist/gtk-dark.css" glib-compile-resources --sourcedir="gtk-3.0" "gtk-3.0/gtk.gresource.xml" make[1]: Leaving directory '/home/n1l/.themes/oomox-333voidmachineV2'

actionless commented 1 month ago

i've opened the app, changed first of the colors, background, to a new color in the very first theme (blueloco), exported and it works 🤷

333voidGirl commented 1 month ago

i've opened the app, changed first of the colors, background, to a new color in the very first theme (blueloco), exported and it works 🤷

Well that's wonderful. Unfortunately, however, that doesn't change my issue.

https://github.com/themix-project/themix-gui/assets/100504210/ac6667ce-fdb3-4d4b-a897-08e6bc9667fa

actionless commented 1 month ago

i've tried repeating exactly the same steps as on your screencast - and it still works

does it works for you if you save the changes before exporting?

333voidGirl commented 1 month ago

No it doesn't. Any theme modified by me using the GUI seems to just stop working. I've also tried using oomox-gui instead just in case there's something fucked up with the way I have the apps installed and the issue still occurs. Your guess is likely better than mine as I have no idea why this error occurs.

actionless commented 1 month ago

then upload some of saved themes (ie from ~/.config/oomox/colors/) which currently doesn't work for you

333voidGirl commented 1 month ago

Sure. Here's the theme I'm currently trying to get to cooperate. You can read the output to see which files are erroring and on which lines they are. 333voidMachineV2.zip

333voidGirl commented 1 month ago

My bad misread the directory you wanted files from. Here's the text document for that same theme. 333voidmachineV2.txt

actionless commented 1 month ago

thanks, apparently setting some combinations of colors to exactly #000000 causing division by 0 in the scss code:

https://github.com/themix-project/oomox-gtk-theme/blob/master/src/gtk-3.20/scss/_functions.scss#L141

i'll look into it