search

thenbrent / paypal-digital-goods

The missing PayPal Digital Goods PHP library. Discontinued - PayPal no longer offer the Digital Goods product.
Other
121 stars 38 forks source link

option to show/hide address #33

Closed TimSprattVS closed 9 years ago

TimSprattVS commented 9 years ago 
Determines where or not PayPal displays shipping address fields on the PayPal pages. For digital goods, this field is required, and you must set it to 1. It is one of the following values:

0 – PayPal displays the shipping address on the PayPal pages.
1 – PayPal does not display shipping address fields whatsoever.
2 – If you do not pass the shipping address, PayPal obtains it from the buyer's account profile. Character length and limitations: 1 single-byte numeric characters.

I figured since this is a digital goods repo and they say For digital goods, this field is required, and you must set it to 1 we should default this to 1, but give the option to overwrite.

Do you think the example needs updating?

@thenbrent

thenbrent commented 9 years ago

Thanks for the PR @TimSprattVS.

we should default this to 1, but give the option to overwrite.

That sounds sane. Given that this library could be used for standard Express Checkout (or at least, as a base for an Express Checkout library), it makes sense to make it possible to overwrite it.

By keeping the display address property undocumented, hopefully we're also not creating a trap for new players. ;)