thennothinghappened / GMEdit-Constructor

https://github.com/YAL-GMEdit/builder, but uses Igor!
MIT License
13 stars 2 forks source link

User folder selection + lots of other stuff #19

Closed CST1229 closed 5 months ago

CST1229 commented 6 months ago

This PR was originally planned to just add a user selection to fix compiling executables, but it ended up becoming... this.

Resolves #18 Partially addresses #16 (adds a user folder path, but you still have to specify the runtimes folder too) Resolves #15 Resolves #13 Resolves #5

This is my first time doing really anything related to GMEdit plugins, so there might be lots of bad code and issues.

thennothinghappened commented 6 months ago

Hello!

Firstly just want to say thank you so much for this - I've not had time to do this work on Constructor so I really appreciate this. I had a look over it this morning briefly and the main issues I have are nitpicks just to make sure there's a consistent style going on. I'll add those as review comments when I can but overall looks good. I'll give this a test on my machine when I'm in GMEdit.

thennothinghappened commented 5 months ago

Looks like you've fixed up most of what I pointed at, thanks again!! Again I'll have to look at it properly tomorrow at the soonest though, its quite late and I'm quite sick at the moment.

thennothinghappened commented 5 months ago

Also glad to see rm swapped out for flags, I'm much happier with that.

thennothinghappened commented 5 months ago

Looks like Node isn't a big fan of paths using ~:

image

I'd just swap ~ for process.env.HOME.

thennothinghappened commented 5 months ago
image

I've done that here and it fixed it on my end.

thennothinghappened commented 5 months ago
image

Not entirely sure why but we seem to have lost the GMEdit "normal" preferences. The control panel is the "proper" way for this now so I might have a look at fixing this as well later to get this merged sooner.

thennothinghappened commented 5 months ago

Can confirm YYC working on MacOS, fantastic!!

image