[RFC] Build container with public services

[Nek-]

Hello guys. First thanks for this nice bundle :) .

This is about providing a new idea for the bundle, I don't know how to do it but it would be useful.

• Context: In Symfony4, all services are private by default
• Problem: if you try to access a service via the container injected into psysh you'll get an error: you can't test your services in psysh anymore
• Solution: services must be public inside psysh, in order to allow the developer to debug/use services (it should be at least an option available in the configuration of the bundle)

What do you think about? Any idea of how to implement this?

[theofidry]

I agree with you. Maybe something similar to https://github.com/symfony/symfony/pull/26499 would do

[Nek-]

This PR is a real opportunity indeed. But I think injecting test.service_container instead of the real container into psysh would be a better idea.

This RFC will wait for Symfony 4.1 :) .

[theofidry]

Yeah although we can always go ahead and I'll just tag it once 4.1 is out :)

[kubk]

Hello @theofidry , thanks for the Bundle. I tried to use Psysh bundle in Symfony 4.1 (beta) with test.service_container and this container works as expected, private services are available in this container.

In order to use test.service_container in Psysh bundle we need to register test.service_container in dev environment (currently this service available only in test environment: https://github.com/nicolas-grekas/symfony/blob/a840809e5dad429c95eafe40b5dd2ea593a7a232/src/Symfony/Bundle/FrameworkBundle/Resources/config/test.xml)

So I think adding support for test.service_container in Psysh bundle must be implemented without BC break.

I tried to change this line: https://github.com/theofidry/PsyshBundle/blob/160c95a55f2085ab6f90eacc74569620f6f158ae/src/DependencyInjection/PsyshExtension.php#L48 to

'container' => $container->hasDefinition('test.service_container') ? new Reference('test.service_container') : new Reference('service_container'),

but $container->hasDefinition('test.service_container') always returns false, even if the service is registered. But it will work if I change this line to

'container' => new Reference('test.service_container'),

Did I miss something? Here is my services.yml:

    service_locator:
        class: Symfony\Component\DependencyInjection\ServiceLocator
        arguments: [['@session']]
        tags: [container.service_locator]

    test.service_container:
        class: Symfony\Bundle\FrameworkBundle\Test\TestContainer
        public: true
        arguments:
             - null
             - '@service_container'
             - '@service_locator'

[theofidry]

Hello :)

but $container->hasDefinition('test.service_container') always returns false, even if the service is registered.

If you registered it yourself then it's likely that the bundle is ran before your services are registered. So maybe this part (the Psysh one) should be done later

[kubk]

@theofidry Thanks for the response, you are right. I think we have 2 options:

• Copy & paste service definitions from https://github.com/symfony/symfony/blob/master/src/Symfony/Bundle/FrameworkBundle/Resources/config/test.xml to resources/config/services.xml of the Psysh bundle.
• Load this test.xml file using XmlFileLoader and FileLocator in PsyshExtension. This approach is better because no copy & paste but still we need to hardcode path to FrameworkBundle/Resources/config/test.xml

Which option do you prefer? I can make a PR.

[theofidry]

I'm fine with the second, this bundle is bound to be tightly coupled to framework bundle anyway

[theofidry]

Closed by #38