Closed leptos-null closed 6 months ago
This reverts commit 556ca6f544bb3a5db195a4ce9c5a94446946a49b
The changes made in the referenced commit do not seem to be compatible with { Xcode 11/ the associated Swift version } which is used for releases: https://github.com/theos/orion/blob/dd60a11d0fec56a52d5c6bf0850340e90748f16a/.github/workflows/release.yml#L38
Yes: #32
No
Added #34 to avoid issues in the future where "tests" passes for code that will not work on the "release" workflow.
Operating System: macOS
Platform: Darwin
Target Platform: iOS
Toolchain Version: Xcode 11.7
SDK Version: 13
What does this implement/fix? Explain your changes.
This reverts commit 556ca6f544bb3a5db195a4ce9c5a94446946a49b
The changes made in the referenced commit do not seem to be compatible with { Xcode 11/ the associated Swift version } which is used for releases: https://github.com/theos/orion/blob/dd60a11d0fec56a52d5c6bf0850340e90748f16a/.github/workflows/release.yml#L38
Does this close any currently open issues?
Yes: #32
Any relevant logs, error output, etc?
No
Any other comments?
Added #34 to avoid issues in the future where "tests" passes for code that will not work on the "release" workflow.
Where has this been tested?
Operating System: macOS
Platform: Darwin
Target Platform: iOS
Toolchain Version: Xcode 11.7
SDK Version: 13