search

thephpleague / tactician-bundle

Bundle to integrate Tactician with Symfony projects
MIT License
245 stars 43 forks source link

Remove Symfony 4.2 deprecation #107

Closed jildertmiedema closed 5 years ago

rosstuck commented 5 years ago

Looks good, thanks for picking this up! I'll merge when I get home in a few days. :)

On Fri, Dec 7, 2018, 12:06 AM Jildert Miedema <notifications@github.com wrote:

You can view, comment on, or merge this pull request online at:

https://github.com/thephpleague/tactician-bundle/pull/107 Commit Summary

  • Remove Symfony 4.2 deprecation

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/thephpleague/tactician-bundle/pull/107, or mute the thread https://github.com/notifications/unsubscribe-auth/AAI9TstGdwBHvovJi2rEwLUfObjPLj22ks5u2TKLgaJpZM4ZGsBA .

tabbi89 commented 5 years ago

Ping :P

rosstuck commented 5 years ago

I appreciate the pings and approves, fellas, but this PR has failing tests. If you'd like it merged faster, then that would be more help.

One of them looks like a quick change to travis.yml to exclude 7.0+Symfony 4.2 from the build matrix (good starter issue @tabbi89?)

The other ones are in the SecurityVoter tests, not sure what's up with that? Did that component change in the 4.2 release? The test failure messages aren't super helpful, unfortunately. :-/ https://travis-ci.org/thephpleague/tactician-bundle/jobs/464385869

chalasr commented 5 years ago

Failing tests are fixed by #109 (precisely https://github.com/thephpleague/tactician-bundle/pull/109/commits/002482c26a72f81ef0120bf461f9712ba8f3d8c5), merging it should unlock this one

PabloKowalczyk commented 5 years ago

@chalasr after #109 merge there will be no changes in this PR :)

rosstuck commented 5 years ago

Closed in favor of #109. Sorry @jildertmiedema, I appreciate the work though and next time I see you, drinks are on me. :)