search

thephpleague / tactician-bundle

Bundle to integrate Tactician with Symfony projects
MIT License
245 stars 43 forks source link

DebugCommand return value #123

Open hafkenscheid opened 4 years ago

hafkenscheid commented 4 years ago

When using the debug command (debug:tactician), I get the following error:

In Command.php line 258:
   Return value of "League\Tactician\Bundle\Command\DebugCommand::execute()" must be of the type int, "NULL" returned.
rosstuck commented 4 years ago

Hmm, can you let me know what Symfony version you're using? I think they began requiring a return value in 5+ so this is likely fixed by adding a return 0 at the end of the DebugCommand...

hafkenscheid commented 4 years ago

Jup, SF 5.0 Furthermore, the docs are also not very up to date with SF5.0

rosstuck commented 4 years ago

Truthfully, I haven't used Symfony in years, so if you've got some doc updates you can put in a PR, I'll gladly merge them. :)

Same for the return 0, otherwise I'll get to it this weekend or so.

On Thu, Jul 2, 2020, 8:02 PM Rogier Hafkenscheid notifications@github.com wrote:

Jup, SF 5.0 Furthermore, the docs are also not very up to date with SF5.0

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/thephpleague/tactician-bundle/issues/123#issuecomment-653147807, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABD2TUED26YLSPDYR7OI5TRZTDSLANCNFSM4OKFI52A .

PabloKowalczyk commented 2 years ago

@hafkenscheid Is it solved by https://github.com/thephpleague/tactician-bundle/pull/130?