Remove PHP8 deprecation notices

thephpleague / tactician-bundle

Bundle to integrate Tactician with Symfony projects

MIT License

245 stars 43 forks source link

Remove PHP8 deprecation notices #125

Closed acasademont closed 3 years ago

acasademont commented 3 years ago

And also:

Bump minimum PHP to 7.2
Bump PHPUnit to 8.5
Remove unneeded Travis dependencies (although this should be probably moved to Github Actions)

fixes #124

acasademont commented 3 years ago

PS: I assumed handlers with PHP8 Union Types should not be registered. Let me know if you think otherwise @rosstuck , thx!!

rosstuck commented 3 years ago

Agreed on the union types, I feel like any handler that's receiving more than one command is probably doing something fishy, so let's not add to that.

Otherwise, thanks a ton for picking this up! I like the PR and it seems like you're transitioning everything nicely. The only thing I'd tweak is making this 1.3 since it drops earlier PHP version support.

Seems like just a few failing tests still and then I'm happy to merge and tag. Thanks once again! :heart:

acasademont commented 3 years ago

Yes, dealing with multiple symfony and phpunit versions can be a bit of a PITA. Plus Travis seems to take hours these days. Everything should be ready now :D

rosstuck commented 3 years ago

This is just a genuinely lovely PR, thank you so much for picking this up and handling it so well. Much :heart:, I really appreciate it. :smile:

acasademont commented 3 years ago

Thanks @rosstuck, my pleasure!