search

thepowersgang / mrustc

Alternative rust compiler (re-implementation)
MIT License
2.18k stars 109 forks source link

Never use section on aarch64 (#277) #292

Closed catap closed 2 years ago

catap commented 2 years ago

Closes #277

catap commented 2 years ago

@thepowersgang I not sure about condition. Maybe invert it and keep section attribute only for x86 and x86_64 is better idea.

catap commented 2 years ago

@thepowersgang just a reminder about this one

catap commented 2 years ago

@thepowersgang ping here!

thepowersgang commented 2 years ago

I'm not sure hard-disabling the use of section annotations is the correct solution to that linked issue. Wouldn't adding patch for that particular bad annotation be a better solution?

catap commented 2 years ago

@thepowersgang I haven't found the place in sources which triggers such behaviour. Anyway, section isn't supported at aarch64 => seems logical to not use it.

thepowersgang commented 2 years ago

If that's the case - then include that in the commit and in a source comment

catap commented 2 years ago

@thepowersgang seems I found much better solution.

I've started to find any proof that aarch64 doesn't support section and haven't found one. In fact I found that it should work.

=> I've started digging as you suggested and found an issue in rust-curl which is used. This issue was fixed in upstream. So, I've backported it to rust-curl which is used for 1.54.0 :)

catap commented 2 years ago

Thus, you may see that original issue https://github.com/alexcrichton/curl-rust/issues/417 is near the same that I had at the end of https://github.com/thepowersgang/mrustc/issues/277:

  = note: ld: reference to symbol (which has not been assigned an address) __ZN4curl4init9INIT_CTOR17h97cc33cf050cb462E in '__ZN4curl4init17ha644d831c2a57f65E' from /Users/cormac/git/tryout/libcurl-monterey/target/debug/deps/libcurl-0f9cbb7dde66dd88.rlib(curl-0f9cbb7dde66dd88.curl.0b6dcf6e-cgu.2.rcgu.o) for architecture arm64
          clang: error: linker command failed with exit code 1 (use -v to see invocation)