theseer / phpdox

Documentation generator for PHP Code using standard technology (SRC, DOCBLOCK, XML and XSLT)
http://phpdox.de
Other
600 stars 121 forks source link

Exclude does nothing #66

Closed williamjulianvicary closed 10 years ago

williamjulianvicary commented 12 years ago

When trying to add exclude paths it doesn't appear to have an affect on the output I've tried all different exclude masks I could think of, including altering the include mask to an exclude without effect - this document is definitely being included as I can break it by adding rubbish to it.

<phpdox xmlns="http://phpdox.de/config">
 <project name="Project X" source="src" workdir="build/phpdox">
  <collector publiconly="false">
   <include mask="*.php" />
   <exclude mask="**external**" />
  </collector>

  <generator output="build">
   <build engine="html" enabled="true" output="api"/>
  </generator>
 </project>
</phpdox>
theseer commented 12 years ago

I finally had some time to try to reproduce your problem, but I cannot on my development version. The logic behind the filter is a simple fnmatch function call btw..

theseer@rikka ~/storage/php/phpdox master $ grep "exclude" phpdox.xml.dist && ./phpdox.php

phpdox %development% - Copyright (C) 2010 - 2012 by Arne Blankerts

[...]

cccccccccccccccccccccccccccccccccccccccccccc [44]

versus

theseer@rikka ~/storage/php/phpdox master $ grep "exclude" phpdox.xml.dist && ./phpdox.php

phpdox %development% - Copyright (C) 2010 - 2012 by Arne Blankerts

[...]

cccccccccccccccccccccccccccccccccccccccccccccccccc [50] ccccccc [57]

williamjulianvicary commented 12 years ago

Hmm this is odd - it appears that the collector is excluding as expected, however when it comes to the generator it appears to scan the full data set again - the documentation this has created is full of unused classes within the /external/ folder (Zend framework and an internal library).

Is there a different exclusion protocol for the generator?

williamjulianvicary commented 12 years ago

I think I have figured this out - is there some kind of caching involved with the generator process? Clearing my workspace in Jenkins has sorted this, using the same SVN source.

Hope this helps!

seyfer commented 11 years ago

@williamvicary method resolv my issue too

[https://github.com/theseer/phpdox/issues/111]

theseer commented 10 years ago

As the cache handling has been rewritten as well as the config change detection implemented, I close this ticket. If the problem remains, please open a new ticket.