search

thesofproject / linux

Linux kernel source tree
Other
91 stars 133 forks source link

ACPI: add helper to read 64-bit address #5001

Closed plbossart closed 6 months ago

plbossart commented 6 months ago

Based on comment from @charleskeepax

@andy-shev comments?

andy-shev commented 6 months ago

Based on comment from @charleskeepax

@andy-shev comments?

Sure. The idea of the initial helper was to have more users that want to retrieve either "reg" (OF) or _ADR (ACPI) value (if you look at the current users). Since all of them so far are using 32-bit version, and there only three of them, I would rename original helper to have _u32 in its name, since we might want to have 64-bit version of the common helper as well. Otherwise I have no objections.

plbossart commented 6 months ago

@andy-shev I thought about renaming but that'd be interesting with changes across 3 subsystems, in addition to ACPI.

drivers/i2c/muxes/i2c-mux-gpio.c:                       rc = acpi_get_local_address(ACPI_HANDLE_FWNODE(child), values + i);
drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c:                       err = acpi_get_local_address(ACPI_HANDLE_FWNODE(child), &id);
drivers/net/mdio/acpi_mdio.c:           ret = acpi_get_local_address(ACPI_HANDLE_FWNODE(child), &addr);

I try to avoid such cross-tree changes since they take time. I already have changes across ACPI, ASoC, ALSA, SoundWire which could be fun to deal with :-)

Maybe we can rename the original helper with u32 in a follow-up patch, to avoid having 7 subsystems involved at the same time.

andy-shev commented 6 months ago

I'm fine with doing this in the followup, but please send them as a series, so the maintainers will be at least aware of this change.

plbossart commented 6 months ago

I'm fine with doing this in the followup, but please send them as a series, so the maintainers will be at least aware of this change.

Not sure I understand, a rename is usually a single patch, or we need to add a new helper, do the rename and then remove the old helper. Is this what you meant by 'series' @andy-shev ?

andy-shev commented 6 months ago

I'm fine with doing this in the followup, but please send them as a series, so the maintainers will be at least aware of this change.

Not sure I understand, a rename is usually a single patch, or we need to add a new helper, do the rename and then remove the old helper. Is this what you meant by 'series' @andy-shev ?

I meant to add that patch to this series.