Open pviscone opened 2 months ago
Ok, I have applied all the comments.
If True, the shared library will be looked for in the same directory as the JSON file, using the timestamp of the last metadata entry available
If False, the shared library will not be loaded
If a string, it could be:
- path to the shared library to load for the model
- path to the directory where to look for the .so file, using the timestamp of the last metadata entry available
No shared library will be loaded if a new configuration is provided
I think the code changes for the library reloading are now good, but I'd like to see more tests:
Did you get a chance to resolve the comments above RE more robust testing?
When a conifer JSON model is loaded conifer is not able to load also the conifer_bridge.so shared libraries (if they were already produced).
This implies:
This PR tries to fix this behavior by looking for the shared library with the last timestamp present in the metadata. It looks for it in the same folder of the JSON if the is not specified by the user. It works for both the xilinx and cpp backends.