search

thetwom / toc2

Metronome app
GNU General Public License v3.0
162 stars 23 forks source link

Timing seems off #3

Closed T-vK closed 4 years ago

T-vK commented 4 years ago

Hey, I just found your app on F-Droid and I really like the concept. But when I hit play, something is off. Especially the hi-hats don't seem consistent. sample.zip Maybe it would make sense to generate one long audio file and play that to avoid delays that come with looping and chaining audio files in real-time?

thetwom commented 4 years ago

thanks for the report, will took into it shortly. Sorry, for not answering before. Github didn't send me any mails, so I didn't know about it ...

T-vK commented 4 years ago

No problem, thanks for the reponse.

thetwom commented 4 years ago

just to get it right: What you mean is, that when mixing different sounds they are not perfectly on point? So e.g. hi-hat seems to play too early? Or do you mean that every now and then some sound is off?

T-vK commented 4 years ago

No it's actually even noticable with only hi-hats. The silence between each hi-hat is not consistent. Sometimes the delay between two hi-hats is a couple of milliseconds longer. And by sometimes I mean like every 3-7 beats, it's different every time.

thetwom commented 4 years ago

ok, thanks for the clarification. Seems that I have to stabilize the clock somehow. I will see what I can do.

thetwom commented 4 years ago

I tried to improve the timing, but unfortunately android brings no convenient functions to do this. And I guess its strongly dependent on the device. I will see if I can some up with some better idea in future, but maybe the newest version already brings some improvement. Would appreciate your feedback.

Will upload it to play store during the next days. fdroid should update automatically.

T-vK commented 4 years ago

Thanks, I'm using F-Droid. I'll report back when I get the update. Maybe have a look at the "Drum On!" source code. I'm not sure if it's 100% perfect, but it seems good enough for me: https://github.com/tube42/drumon

T-vK commented 4 years ago

I just got the update from F-Droid, unfortunetely I couldn't hear a difference. It's still not consistent. :/

thetwom commented 4 years ago

I feared that. However, I have a new core in the pipeline, which should really solve the problem! It will take some more time to get it integrated ... Anyway, thanks for testing.

T-vK commented 4 years ago

That's great to hear. Thanks for your work.

thetwom commented 4 years ago

I did a prerelease with the new player logic. Up to now it works flawless for me, but maybe you are willing to test it before I tag it as release such that it is captured by fdroid. In case you are willing to test you find the apk under the 1.6.0-release (link). I would be interested if the metronome is accurate now, if the user interface is reactive and if there are any crashes.

T-vK commented 4 years ago

Just tested it and it sound pretty good. I can't hear any inconsistencies anymore. The UI is responsive, reactive and I got not crashes.

Good job!

thetwom commented 4 years ago

That's great to hear. Thanks for your immediate testing and support!

I will also see how it performs on my mobile during the next days and then tag the release. In theory everything should by consistent now, but it's quite a big change, so I better give it some time.

T-vK commented 4 years ago

I agree. If I run into any issues with the test release I'll let you know.

T-vK commented 4 years ago

Found a bug. You can't tap in the tempo without getting a crash until you hit the play button at least once. This resets every time you restart the app.

thetwom commented 4 years ago

Thanks for the report. It seems as I already fixed this, since I can reproduce it with the 1.6.0 version but not with my latest developer version, where I basically cleaned up the code a bit. Will upload the new version soon.