search

thewh1teagle / rookie

Load cookies from your web browsers
https://crates.io/crates/rookie
MIT License
204 stars 18 forks source link

Add Cachy Browser #27

Closed ShayBox closed 7 months ago

ShayBox commented 7 months ago

I added support for Cachy Browser which is a fork of Firefox that's only officially available on CachyOS for Linux, someone could probably build it for Windows or macOS but it's very unlikely.

I also formatted and linted the code using rust and cargo's builtin rustfmt and clippy tools, this should probably be a commit and pull request CI check.

I also noticed zvariant, zbus, and windows are outdated but decided to leave them alone because of the extensive changes needed for the first two, but I changed all the dependency versions to remove the unused minor/patch versions as without the = prefix they are ignored by cargo, only the major number is used.

thewh1teagle commented 7 months ago

Looks good! What settings did you used for formatting? I'm wondering if we should add default format settings for the repo inside .vscode/settings.json or rustfmt.toml or let the user use his own format settings (not sure where) And maybe even format tests similar to tauri/workflows/lint-cli.yml

ShayBox commented 7 months ago

Just the default settings for rustfmt without a config file. Rust has default format rules as long as you tell your editor to format on save or press the format button.