Maintenance: Use Python 3 and venv

thiagoralves / OpenPLC_v3

OpenPLC Runtime version 3

1.02k stars 421 forks source link

Maintenance: Use Python 3 and venv #218

Closed lhartmann closed 10 months ago

lhartmann commented 10 months ago

Updates to enable running on modern distributions:

Duplicate code on calls to runtime refactored onto _rpc(...).
Python 2 is dead, long live python 3.
Can't use pip on externally managed environments, so use venv.
Wiringpi is missing on some distros, so add alternate install from github.

Tested install, launch blank program, start runtime, monitor and stop runtime under:

docker/debian:latest
docker/ubuntu:latest
docker/fedora:latest
raspberry pi, dietpi (based on debian 12)

Untested:

raspberry pi, other distributions.
windows
ethercat
non-blank programs

thiagoralves commented 10 months ago

Nice! Thanks for the contribution again. Let me test it at least on Windows and Linux first to make sure it is working the same way before merging this PR. By the way, have you checked the dev-python3 branch at https://github.com/Autonomy-Logic/OpenPLC_Runtime/tree/feature/mbconfig_generator ? Maybe we can join forces to build the next version of the runtime.

lhartmann commented 10 months ago

Windows/cygwin will probably fail because I have not changed it's installer to python3. There are 2 possible solutions:

Update windows' portion of the install script to python3.
Change f'strings' do 'string'.format() so as to retain python2 compatibility.

My choice would be the first option. Looks easy enough...

thiagoralves commented 10 months ago

I merged your PR and made the necessary modifications for the runtime to run on Python 3 Windows. Thank you for working on this. If you want to continue contributing, please check https://github.com/Autonomy-Logic/OpenPLC_Runtime (dev-python3 branch). That's the new version of the runtime that eventually will replace this one.