search

thibautjombart / apex

Phylogenetic Methods for Multiple Gene Data
5 stars 3 forks source link

apex needs phangorn release #37

Closed thibautjombart closed 9 years ago

thibautjombart commented 9 years ago

@KlausVigo CRAN asked me to release a fix for apex, but I realized it now requires the latest (github) version of phangorn. Any chance you can make a release soon?

thibautjombart commented 9 years ago

For the record, here is the warning we get testing apex with CRAN version of phangorn:

* checking R code for possible problems ... NOTE
multiphyDat2alignment: no visible global function definition for
  ‘phyDat2alignment’
Undefined global functions or variables:

We don't get it with the github version.

KlausVigo commented 9 years ago

@thibautjombart, I am checking phangorn and dependent packages for submission. If most/all tests are fine I will submit it tomorrow. Wish me luck.
Do you have set up a nice testing environment, e.g. docker for future submissions??

zkamvar commented 9 years ago

FWIW, I wrote up a little entry in poppr's wiki about using docker for testing: https://github.com/grunwaldlab/poppr/wiki/R-CMD-check-with-docker-rocker

Although, the updates are relatively sporadic, but once you have the container set up, it's quite nice.

KlausVigo commented 9 years ago

Submitted. Let's pray to the R gods, that it gets accepted ;)

thibautjombart commented 9 years ago

May the force be with us.

On Thu, Jul 9, 2015 at 4:08 PM, klash notifications@github.com wrote:

Submitted. Let's pray to the R gods, that it gets accepted ;)

— Reply to this email directly or view it on GitHub https://github.com/thibautjombart/apex/issues/37#issuecomment-120021709.

KlausVigo commented 9 years ago

Success!!