CRAN release - Githubissues

thibautjombart / apex

Phylogenetic Methods for Multiple Gene Data

5 stars 3 forks source link

CRAN release #46

Closed EricArcher closed 8 years ago

EricArcher commented 8 years ago

I'm ready to submit strataG to CRAN, but winbuilder is throwing errors because of the recent apex accessor changes. If you feel its stable, could the current version of apex be uploaded to CRAN?

zkamvar commented 8 years ago

Is there a table listing the current accessor changes? This would be handy to avoid things breaking in this vignette: http://popgen.nescent.org/PopDiffSequenceData.html

EricArcher commented 8 years ago

The two main changes were:

The accessor setLocusNames was added to match getLocusNames (the vignette seems to use locusNames)
The accessors getNumSequences, getSequenceNames, and getSequences all have the same exclude.gap.only argument with the default of TRUE.

thibautjombart commented 8 years ago

I don't have any objection. Anyone against?

EricArcher commented 8 years ago

Not to be pushy, but if it's all good, can we submit?

thibautjombart commented 8 years ago

Oh gosh, please push, I had forgotten about it. ':-/

thibautjombart commented 8 years ago

Just submitted. Fingers crossed.

thibautjombart commented 8 years ago

One CRAN!