search

thom4parisot / grunt-crx

Grunt task used to package private Chrome Extensions.
https://npmjs.com/grunt-crx
MIT License
118 stars 21 forks source link

Indicate that `zip` binary is also a dependency #29

Closed chrisirhc closed 11 years ago

chrisirhc commented 11 years ago

Ran into this and spent quite some time because of #28 (couldn't find the problem until I did --stack).

thom4parisot commented 11 years ago

Yes, actually it's a dependency from the crx package. Agreed it should be mentioned.

I'd like at some point every system dependency could be replaced by a pure JS one.

Don't hesitate to provide a PR mentioning it the way you feel is the best (I guess you are a Windows user?) because this is not the kind of missing command which happens on *NIX systems.

Thanks :-)

ehrlich-b commented 11 years ago

There should be no more zip dependency in the latest version of crx. Can you make sure you are on the latest version and post the stack?

chrisirhc commented 11 years ago

My bad. zip was a dependency in grunt-crx 0.2.6 but now it isn't because crx 0.4.0 doesn't require it.

thom4parisot commented 11 years ago

No worries. Thanks @adotout for coining the version issue. I almost forgot about it ;-)