search

thom4parisot / grunt-crx

Grunt task used to package private Chrome Extensions.
https://npmjs.com/grunt-crx
MIT License
118 stars 21 forks source link

Package (npm) is out of date #61

Closed alantheprice closed 9 years ago

alantheprice commented 9 years ago

The package in npm is out of date and doesn't include several fixes.

thom4parisot commented 9 years ago

Thanks @alanPriceWandCorp for the report. Can you be more precise of what makes you thinking it is out of date?

Each git tag matches a correspondant npm version (via npm view grunt-crx versions).

Unless you mean master contains feature and fixes which have not been published on npm yet?

Let us know :-)

alantheprice commented 9 years ago

I guess maybe I was mistaken, but on the npm site it says the most current version is 0.3.4. Also, when I did an npm install it also installed version 0.3.4. According to the npm view grunt-crx versions it shows more current releases.

To fix, I specified the most current version (as of this comment) 1.0.3 and ran an npm install. This did fix the issue and brought me up to the latest version. I don't know if there is a way to tell npm to serve the most recent by default because that would have helped in this situation.

The core issue is what version npm is serving by default, not with the package being out of date.

Thanks for a useful tool!

thom4parisot commented 9 years ago

This is mainly due to #44 – which could be easily fixable by using node-glob to ignore patterns of files in crx directly.

alantheprice commented 9 years ago

Ah, that makes sense. I will continue using 1.0.3 since I don't need to ignore files. Thanks for the heads up!

It would probably be helpful if you specified that at the top of the readme, it might reduce some of the issues that have been logged eg. #45, which I also ran into. Maybe just a "Note: v0.3.4 has been tagged as the latest version to avoid security issues in packaged extensions. See issue #44."

Thanks,

thom4parisot commented 9 years ago

@alanPriceWandCorp good idea! Please propose a PR and I'll be happy to merge it :-)