thomasjo / atom-latex

Compile LaTeX or knitr documents from within Atom
https://atom.io/packages/latex
MIT License
223 stars 42 forks source link

Incompatible Packages #375

Closed trentks closed 7 years ago

trentks commented 7 years ago

Upon launching with this package enabled I am greeted with a bug:

[Enter steps to reproduce:]

  1. Install and enable latex package
  2. Relaunch atom
  3. Can confirm disabling the latex package and relanching atom removes the error

Atom: 1.16.0 x64 Electron: 1.4.16 OS: "Manjaro Linux" Thrown From: incompatible-packages package 0.27.2

Stack Trace

Uncaught Error: Invalid child node: undefined

At /usr/lib/atom/node_modules/incompatible-packages/node_modules/etch/lib/dom.js:25

Error: Invalid child node: undefined
    at Object.dom (/usr/lib/atom/node_modules/incompatible-packages/node_modules/etch/lib/dom.js:25:15)
    at /usr/lib/atom/node_modules/incompatible-packages/lib/incompatible-packages-component.js:203:31
    at Array.map (native)
    at IncompatiblePackagesComponent.renderIncompatibleModules (/usr/lib/atom/node_modules/incompatible-packages/lib/incompatible-packages-component.js:199:34)
    at IncompatiblePackagesComponent.renderIncompatiblePackage (/usr/lib/atom/node_modules/incompatible-packages/lib/incompatible-packages-component.js:152:63)
    at Array.map (native)
    at IncompatiblePackagesComponent.renderIncompatiblePackageList (/usr/lib/atom/node_modules/incompatible-packages/lib/incompatible-packages-component.js:128:35)
    at IncompatiblePackagesComponent.render (/usr/lib/atom/node_modules/incompatible-packages/lib/incompatible-packages-component.js:79:14)
    at updateSync (/usr/lib/atom/node_modules/incompatible-packages/node_modules/etch/lib/component-helpers.js:99:34)
    at /usr/lib/atom/node_modules/incompatible-packages/node_modules/etch/lib/component-helpers.js:72:7
    at DefaultScheduler.performUpdates (/usr/lib/atom/node_modules/incompatible-packages/node_modules/etch/lib/default-scheduler.js:48:34)

Commands

Non-Core Packages

latex 0.43.0 

This is a fresh install of manjaro kde, with atom 1.16.0 x64 and latex 0.43.0. There are no other non-default atom-packages. This all works fine on my laptop running manjaro i3, with atom 1.16.0 x64 and latex 0.43.0.

yitzchak commented 7 years ago

This is probably related to #360.

tomrunia commented 7 years ago

Same problem on MacOS Sierra with Atom 1.17.2 and latex 0.43.0

yitzchak commented 7 years ago

@tomrunia @trentks Just released v0.44.0, can you verify that problem still exists after updating?

danielleontiev commented 7 years ago

Atom 1.18.0. Same problem. Click "rebuild button" helps but latex package keep saying it can be upgraded to version > then 0.44.0 but cannot because of my atom version

yitzchak commented 7 years ago

@danielleontiev You probably need v0.44.0 but not v0.44.1 since it requires Atom 1.19.0. Try uninstalling the latex package then do apm install latex@0.44.0 from the command line.

danielleontiev commented 7 years ago

@yitzchak It works, thanks

yitzchak commented 7 years ago

@danielleontiev Awesome!

mfalt commented 7 years ago

I also get the "Incompatible Packages" error "Some installed packages could not be loaded because they contain native modules that were compiled for an earlier version of Atom." "build@unknown – Cannot find module '/local/home/mattiasf/.atom/packages/latex/node_modules/abstract-socket/build'" when I updated to atom "1.19.0" and atom-latex "0.45.0". Rebuilding doesn't help.

yitzchak commented 7 years ago

@mfalt What OS are you on?

mfalt commented 7 years ago

Fedora 24 or 25, can verify in an hour. Everything worked fine before updating these packages.

On Thu, Aug 10, 2017, 11:57 Tarn Burton notifications@github.com wrote:

@mfalt https://github.com/mfalt What OS are you on?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/thomasjo/atom-latex/issues/375#issuecomment-321507386, or mute the thread https://github.com/notifications/unsubscribe-auth/ADFlScQJmlZIe8Y5TEsnC7BZUSQmyZcMks5sWtQZgaJpZM4NhLgU .

yitzchak commented 7 years ago

@mfalt What PDF viewer do you use?

mfalt commented 7 years ago

Evince

On Thu, Aug 10, 2017, 12:02 Tarn Burton notifications@github.com wrote:

@mfalt https://github.com/mfalt What PDF viewer do you use?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/thomasjo/atom-latex/issues/375#issuecomment-321508397, or mute the thread https://github.com/notifications/unsubscribe-auth/ADFlSTe4tAWrpgYPM9W22P2I_5Ik3Visks5sWtUwgaJpZM4NhLgU .

yitzchak commented 7 years ago

@mfalt I would try uninstalling latex and doing a fresh install. From the command line:

apm uninstall latex
apm install latex
cd ~/.atom/packages/latex
apm rebuild

I don't see a --verbose option on apm rebuild but maybe we will get some more info or maybe something has been corrupted. If this doesn't work I'll start trying to research/reproduce the issue. I have not seen it yet on Arch.

mfalt commented 7 years ago

Update: I'm actually running Fedora 23. I tried running make in folder /local/home/mattiasf/.atom/packages/latex/node_modules/abstract-socket/build' and got the error make: *** No rule to make target '../../../../../../../local/home/mattiasf/.atom/.node-gyp/.node-gyp/iojs-1.6.9/common.gypi', needed by 'Makefile'. Stop. so I decided to dnf install node-gyp. After rebuilding latex in atom it said everything went fine and it works after restarting atom now. I did several tries in rebuilding and restarting before installing node-gyp so maybe this is a clue.

yitzchak commented 7 years ago

@mfalt Glad you got it working!

yitzchak commented 7 years ago

Closing. Will reopen if needed.