search

thomasjpfan / redis-cluster-docker-swarm

Redis cluster cache configuration for docker swarm
MIT License
112 stars 46 forks source link

MRG: Fixes issues with Docker 18.06.1 #5

Closed thomasjpfan closed 6 years ago

thomasjpfan commented 6 years ago

Addresses #4

ypereirareis commented 6 years ago

Hi, thanks for the fix.

Can you describe a bit more what was the problem because your fix contains code refactoring and formatting.

A big in your code or something new a docker with the network ?

Thanks !

thomasjpfan commented 6 years ago

Besides the slave IP issue discussed in https://github.com/thomasjpfan/redis-cluster-docker-swarm/issues/4#issuecomment-422045812, there was one more issue with the sentinel IPs. When redis-look first starts, and the sentinels are not running yet, this would case the bootstrapping to fail. I fixed this, by just waiting for the sentinel IPs to appear on the network.

The random formatting comes from adapting a new linter, that prefers tabs over spaces when working with shell scripts. 😅