search

thomasmauerer / hassio-addons

My collection of addons for Home Assistant
MIT License
466 stars 54 forks source link

Ambiguous Formatting for "Host" and "Target Directory" #162

Open elsiehupp opened 11 months ago

elsiehupp commented 11 months ago

"Host" Field

When setting up my configuration, I repeatedly got an error (NT_STATUS_NOT_FOUND). It turned out that this was because I was using a hostname like smb://example.local rather than just example.local.

The instructions for this configuration field could be more helpful if they say to omit the smb://. Or, alternately, the configuration parsing script could automatically strip it out (in order to make it a moot point).

"Target Directory" Field

Additionally, the instructions for "Target Directory" say to leave the field blank in order to use the root directory of the share, but the field in the UI is marked as mandatory, so the field will be highlighted in red if it is left blank. (As far as I can tell, a value of / works the same as leaving the field blank.)

I'm not sure what precisely makes the field appear to be mandatory in the UI, but that should probably be changed so as to avoid a false warning condition.

elsiehupp commented 11 months ago

This is a bit off left field, and I don't know what libraries you have access to, but it could be nice if you added the ability to use something like the gvfs network browser used by gio. I mean, like, for SMB/CIFS, but also potentially for any other supported file protocols. Having to manually enter strings (and keep track of prefixes, formatting, etc.) can be a pain...