thomasmauerer / hassio-addons

My collection of addons for Home Assistant
MIT License
466 stars 54 forks source link

Samba Backup not copied in remote dir when HA Network storage is configured #187

Open morganfw opened 3 weeks ago

morganfw commented 3 weeks ago

Hello, since I configured HA Network Storage, the Samba Backup cannot be able to copy Backup to Samba Share, below the Warning log:

[24-10-31 04:30:47] INFO: Creating backup "Samba Backup 2024-10-31 04:30"
[24-10-31 04:31:38] INFO: Copying backup b6de175b (Samba_Backup_2024_10_31_04_30.tar) to share
[24-10-31 04:31:38] WARNING: b6de175b.tar does not exist
[24-10-31 04:31:38] WARNING: Could not copy backup b6de175b to share. Trying again ...
[24-10-31 04:31:43] WARNING: b6de175b.tar does not exist

To configure Network Storage I followed that path "System - Storage - Add Network Storage", then "System - Backup - (Three dots on top right) Change default backup location" and select new created Network Storage.

Samba Backup Add-on + HA Network Storage combination are good if you want to put 2 backups in 2 different remote locations (eg: 2 NASes or other).

May help me?

Regards

m0nn3 commented 2 weeks ago

Hello everyone,

I have the same problem:

[24-11-04 17:08:34] INFO: Samba Backup started successfully
[24-11-04 17:09:34] INFO: Backup running ...
[24-11-04 17:09:34] INFO: Creating backup "Samba Backup 2024-11-04 17:09"
[24-11-04 17:10:01] INFO: Copying backup 24a5c59c (Samba_Backup_2024_11_04_17_09.tar) to share
[24-11-04 17:10:01] WARNING: 24a5c59c.tar does not exist
[24-11-04 17:10:01] WARNING: Could not copy backup 24a5c59c to share. Trying again ...
[24-11-04 17:10:06] WARNING: 24a5c59c.tar does not exist
[24-11-04 17:10:17] INFO: Backup finished

Here is my configuration:

host: 192.168.178.37
share: container
target_dir: backup/homeassistant
username: m0nn3
password: MyPassword
keep_local: "6"
keep_remote: "6"
trigger_time: "00:42"
trigger_days:
  - Mon
  - Wed
  - Sat
exclude_addons: []
exclude_folders: []

I haven't changed anything, just wondering why there are no more new backups.

I look forward to suggestions for a solution. Best regards m0nn3

chmutoff commented 2 weeks ago

I have exactly the same problem. The backup is being created on the smb share connected to HA but the addon cannot copy the backup from the backup dir located on smb to the smb dir configured in the addon

chmutoff commented 2 weeks ago

The problem is on this line: https://github.com/thomasmauerer/hassio-addons/blob/373b8c5ca49e54e2355e9b8f167fed0b25ac1ffe/samba-backup/rootfs/scripts/main.sh#L59

This addon is looking for a backup located in a /backup folder but since the backups are on the smb share the addon could not find the requested file. Somehow the root backup directory should be provided to the addon and it should have access there.

So when the addon is created the real backup directory should be mapped to it instead of mapping the backup folder https://github.com/thomasmauerer/hassio-addons/blob/373b8c5ca49e54e2355e9b8f167fed0b25ac1ffe/samba-backup/config.yaml#L20

It does not sound very easy to me but maybe this information is helpful to somebody who can fix the issue.