Closed lesichkovm closed 3 years ago
Duplicate of #958
Same question!
Just updated the themes to 5.0.0 very very beta 1.
Check out the v5 branch for more: https://github.com/thomaspark/bootswatch/tree/v5
@thomaspark - some of your themes, namely Darkly and Flatly, can easily be ported to dark mode auto switching using the prefers-color-scheme
media query. I discussed this in my quasi-white-paper The Definitive Guide to Dark Mode and Bootstrap 4, specifically Method 1 (that in turn is based on the techniques shared by Thomas Steiner's (@tomayac) ".. Hello darkness .." blog-post). The fore-mentioned of your themes is an excellent Candidate for this.
I would however love to collaborate with you to bring variants of your themes to v5, and possibly build some dual-scheme themes using Method 4. (Hopefully my pull-request [twbs/bootstrap#32936] lands on favour with the authors.)
PS: I have a port of the V5-β1 at vinorodrigues/bootstrap-dark-5
@thomaspark - some of your themes, namely Darkly and Flatly, can easily be ported to dark mode auto switching using the
prefers-color-scheme
media query. I discussed this in my quasi-white-paper The Definitive Guide to Dark Mode and Bootstrap 4, specifically Method 1 (that in turn is based on the techniques shared by Thomas Steiner's (@tomayac) ".. Hello darkness .." blog-post). The fore-mentioned of your themes is an excellent Candidate for this.I would however love to collaborate with you to bring variants of your themes to v5, and possibly build some dual-scheme themes using Method 4. (Hopefully my pull-request [twbs/bootstrap#32936] lands on favour with the authors.)
PS: I have a port of the V5-β1 at vinorodrigues/bootstrap-dark-5
I would love to see that
Hey @vinorodrigues, I like the idea of dark mode and there's been plenty of interest from others. Most of the themes could be adapted to it with relatively little code.
I prefer method 4 since it doesn't require the end user to do anything differently. As soon as it's officially added upstream, I'll be adding it to the themes. I'd appreciate your help on that. In the meantime, feel free to use any of them to support your proof of concept.
There seems to be a v5.0.1 of Bootstrap now, however, the spacelab theme's SCSS doesn't compile anymore. It uses lighten() and darken() which are no longer available. Is this a known problem? Should I create a separate issue for the spacelab theme?
Also the theme still uses map-get($theme-colors, ...) instead of the new global variables.
As a note, Spacelab is the only swatch using map-get() instead of the global variables. However there are a number of swatches using lighten()/darken() which are now replaced by tint-color() and shade_color() respectively, where the parameters are the same except the percentage param must be doubled.
Thanks for the bug reports. @drauch, can you open two separate issues for map-get() and lighten()/darken()?
I've created #1101 and #1102 👍
v5 was released in fe06eb78c9505ca5fc5746fd1ab71abd8ff47642.
Nice work!
Hi,
Thank you for your hard work, its really appreciated.
The new version of Bootstrap (version 5) is around the corner: https://v5.getbootstrap.com/
Are there preparations underway for it?
Cheers