search

thor0215 / hassio-xfinity-usage

Fetch Xfinity Internet Service Usage Data and publish it to Home Assistant sensor
Apache License 2.0
11 stars 3 forks source link

Infinite loop when usage page not loading #2

Closed tankdeer closed 6 months ago

tankdeer commented 6 months ago

It seems like Xfinity is currently having issues with their site (shocker). If I try to log in manually right now and load the usage page, it tells me it's having issues and logs me out. However when the addon tries to do the same, it appears to get stuck in an infinite loop.

I'm no python dev, but it appears that this current scenario is causing us to get stuck in this portion of the loop, and because it can log in, but not load the page, nothing happens - it just keeps reloading and printing that line in the log file. I'd expect after a few attempts, it would abort and try again on the next scheduled update (Which I set to hourly, as I don't need 15-minute granularity).

Here is a log file except:

INFO: Entering username (URL: https://login.xfinity.com/login)
INFO: Entering password (URL: https://login.xfinity.com/login)
INFO: Updating Session Details
INFO: Didn't get usage data, reloading page (URL: https://customer.xfinity.com/#/devices#usage)
INFO: Updating Session Details
INFO: Updating Session Details
INFO: Didn't get usage data, reloading page (URL: https://customer.xfinity.com/#/devices#usage)
INFO: Updating Session Details
INFO: Updating Session Details
INFO: Didn't get usage data, reloading page (URL: https://customer.xfinity.com/#/devices#usage)
INFO: Updating Session Details
INFO: Updating Session Details
INFO: Didn't get usage data, reloading page (URL: https://customer.xfinity.com/#/devices#usage)
INFO: Updating Session Details
INFO: Updating Session Details
INFO: Didn't get usage data, reloading page (URL: https://customer.xfinity.com/#/devices#usage)
INFO: Updating Session Details
INFO: Updating Session Details
INFO: Didn't get usage data, reloading page (URL: https://customer.xfinity.com/#/devices#usage)
INFO: Updating Session Details
INFO: Updating Session Details
INFO: Didn't get usage data, reloading page (URL: https://customer.xfinity.com/#/devices#usage)
INFO: Updating Session Details
INFO: Updating Session Details
INFO: Didn't get usage data, reloading page (URL: https://customer.xfinity.com/#/devices#usage)
INFO: Updating Session Details
INFO: Updating Session Details
INFO: Didn't get usage data, reloading page (URL: https://customer.xfinity.com/#/devices#usage)
INFO: Updating Session Details
INFO: Updating Session Details
INFO: Didn't get usage data, reloading page (URL: https://customer.xfinity.com/#/devices#usage)
INFO: Updating Session Details
INFO: Updating Session Details

Perhaps as simple as using the retry annotation/decorator that I see used on other methods?

thor0215 commented 6 months ago

I'll add some logic so that it only retries at most 5 time before giving up.