search

thoth-station / odh-dashboard

A dashboard for Open Data Hub, a data science platform on top of OpenShift
GNU General Public License v3.0
0 stars 3 forks source link

[Bug]: notebook images page (AKA CNBi) goes blank #12

Closed codificat closed 1 year ago

codificat commented 1 year ago

Is there an existing issue for this?

Current Behavior

I hit a situation where the /notebookImages page suddenly goes blank.

Firefox's console shows:

TypeError: a is undefined
    Pe CREResourcesTable.tsx:170
    Pe CREResourcesTable.tsx:166
    React 7
    x scheduler.production.min.js:13
    A scheduler.production.min.js:14
react-dom.production.min.js:189:29
Uncaught TypeError: a is undefined
    Pe CREResourcesTable.tsx:170
    Pe CREResourcesTable.tsx:166
    React 7
    x scheduler.production.min.js:13
    A scheduler.production.min.js:14
CREResourcesTable.tsx:170:6

Expected Behavior

No TypeError / page going blank

Steps To Reproduce

I am not fully sure of what triggers this, but I have hit it a couple of times after creating 2 or more Custom Runtime Environments of type "import image".

I'm using Firefox.

I just checked the same page from Chrome (Chromium) and I do not get the error.

Workaround (if any)

No response

What browsers are you seeing the problem on?

No response

Open Data Hub Version

odh-dashboard version cnbi-v0.2.0

Anything else

No response

codificat commented 1 year ago

seeing this with Firefox 107.0 on Fedora 36, not seeing it on Chromium 107.0.5304.110

codificat commented 1 year ago

/wg cre

Gkrumbach07 commented 1 year ago

This error is coming form the sorting in the CRE table on the home page. Upon further investigation, the sorting is not working properly.

Gkrumbach07 commented 1 year ago

/assign @Gkrumbach07

Gkrumbach07 commented 1 year ago

this issue originated form the backend. When etching the CREDetails, the imagestream overwrites any duplicate params with its own. For some reason the image stream was giving undefined for param name. which resulted in errors when sorting on param name.

The fix was to have the CRE resource overwrite the imagestream

codificat commented 1 year ago

This was fixed in #13

Thanks!

/close

sesheta commented 1 year ago

@codificat: Closing this issue.

In response to [this](https://github.com/thoth-station/odh-dashboard/issues/12#issuecomment-1358111464): >This was fixed in #13 > >Thanks! > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.