search

thoth-station / storages

Storage and database adapters for project Thoth
https://thoth-station.github.io/
GNU General Public License v3.0
14 stars 16 forks source link

Unit test Ceph cache and fix timezone awareness #2723

Closed mayaCostantini closed 1 year ago

mayaCostantini commented 1 year ago

Related Issues and Dependencies

Fixes https://github.com/thoth-station/storages/issues/2722 Related to https://github.com/thoth-station/storages/issues/2666

This introduces a breaking change

This should yield a new module release

mayaCostantini commented 1 year ago

/hold

mayaCostantini commented 1 year ago

/unhold

mayaCostantini commented 1 year ago

/retest

mayaCostantini commented 1 year ago

/assign @harshad16 Ready for review

VannTen commented 1 year ago

Btw, side comment: I'm not sure datetime is a good fit for a TTL. For that we don't need fancy handling of timezone/DST, just a unix timestamp, don't we ?

time would probably better. Unfortunately s3 "lastmodified" only give us a datetime. Hum. Let's not bother for now, I'll keep that on a note and see if it warrant another issue.

VannTen commented 1 year ago

/lgtm

sesheta commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: VannTen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/thoth-station/storages/blob/master/OWNERS)~~ [VannTen] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment