thoth-station / storages

Storage and database adapters for project Thoth
https://thoth-station.github.io/
GNU General Public License v3.0
14 stars 16 forks source link

Fix software_environment_id null violation #2748

Closed harshad16 closed 1 year ago

harshad16 commented 1 year ago

Fix software_environment_id null violation Signed-off-by: Harshad Reddy Nalla hnalla@redhat.com

Related Issues and Dependencies

Related-to: https://github.com/thoth-station/storages/issues/2745

This should yield a new module release

Description

Mentioned the details: https://github.com/thoth-station/storages/issues/2745#issuecomment-1377780752

goern commented 1 year ago

/lgtm

goern commented 1 year ago

/approve

sesheta commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: goern, mayaCostantini Once this PR has been reviewed and has the lgtm label, please ask for approval from harshad16 by writing /assign @harshad16 in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/thoth-station/storages/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
harshad16 commented 1 year ago

Thanks all for the review Merging for the release