search

thoth-station / thoth-application

Thoth-Station ArgoCD Applications
GNU General Public License v3.0
12 stars 22 forks source link

[prow] Add branch cleaner plugin configuration #2605

Closed codificat closed 2 years ago

codificat commented 2 years ago

Related Issues and Dependencies

Fixes thoth-station/prescriptions-refresh-job#172

Does this require new deployment ?

Just a deployment of the updated prow config.

Description

This configures the branchcleaner prow plugin so that source branches for merged PRs between two branches on the same repository are automatically deleted.

This can help with e.g. Kebechet PRs or prescription-refresh-job runs.

sesheta commented 2 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please ask for approval from codificat after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[prow/OWNERS](https://github.com/thoth-station/thoth-application/blob/master/prow/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codificat commented 2 years ago

/cc @harshad16

harshad16 commented 2 years ago

/hold

before this can be merged, we have to update the branch-protection config, or else they both would fight for race condition.

harshad16 commented 2 years ago

@codificat please move this pr to https://github.com/operate-first/apps/tree/master/prow and close this one we have migrated prow operations to operate-first.

harshad16 commented 2 years ago

closing this pr, as it needs to be made in operate-first/apps repo. Thank you.