search

thoth-station / thoth-application

Thoth-Station ArgoCD Applications
GNU General Public License v3.0
12 stars 22 forks source link

Expose Thoth version on API endpoints #609

Open fridex opened 3 years ago

fridex commented 3 years ago

Is your feature request related to a problem? Please describe.

See comment in https://github.com/thoth-station/core/pull/247#pullrequestreview-522759294

We should expose version of Thoth in our endpoints (include it in response headers). For this purpose, we should include https://github.com/thoth-station/thoth-application/blob/master/version.py in the build user-api container image.

Describe the solution you'd like

Include https://github.com/thoth-station/thoth-application/blob/master/version.py in user-api container image so that user-api can expose Thoth version information.

Describe alternatives you've considered

Update this manually, but it is error-prone process.

Acceptance Criteria

References

harshad16 commented 3 years ago

https://github.com/thoth-station/core/pull/247#pullrequestreview-522759294

goern commented 3 years ago

/kind feature

harshad16 commented 3 years ago

Ex: x-thoth-version: 0.22.1

harshad16 commented 3 years ago

https://kubernetes.io/docs/tasks/inject-data-application/downward-api-volume-expose-pod-information/

sesheta commented 3 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

goern commented 3 years ago

what is the status of this?

harshad16 commented 3 years ago

plan on providing calender release on the HEADERS of the API endpoint.

sesheta commented 3 years ago

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten.

/close

sesheta commented 3 years ago

@sesheta: Closing this issue.

In response to [this](https://github.com/thoth-station/thoth-application/issues/609#issuecomment-913008811): >Rotten issues close after 30d of inactivity. >Reopen the issue with `/reopen`. >Mark the issue as fresh with `/remove-lifecycle rotten`. > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
harshad16 commented 2 years ago

/lifecycle frozen

codificat commented 2 years ago

plan on providing calender release on the HEADERS of the API endpoint.

I take that as: /triage accepted /assign @harshad16

goern commented 2 years ago

is this something we still want?! @harshad16