search

thothbot / parallax

Cross-platform Java 3D SDK
http://thothbot.github.io
MIT License
84 stars 26 forks source link

multiple code improvements: squid:S1118, squid:S2114, squid:S1155 #78

Closed georgekankava closed 8 years ago

georgekankava commented 8 years ago

This pull request is focused on resolving occurrences of Sonar rules squid:S1118 - Utility classes should not have public constructors. squid:S2114 - Collections should not be passed as arguments to their own methods. squid:S1155 - Collection.isEmpty() should be used to test for emptiness. You can find more information about the issue here: https://dev.eclipse.org/sonar/rules/show/squid:S1118 https://dev.eclipse.org/sonar/rules/show/squid:S2114 https://dev.eclipse.org/sonar/rules/show/squid:S1155 Please let me know if you have any questions. George Kankava

thothbot commented 8 years ago

Thank you for your help