thothbot / parallax

Cross-platform Java 3D SDK
http://thothbot.github.io
MIT License
84 stars 26 forks source link

multiple code improvements: squid:S1905, squid:S1068, squid:S1155, squid:S1854, squid:CommentedOutCodeLine, squid:S1118 #80

Closed georgekankava closed 8 years ago

georgekankava commented 8 years ago

This pull request is focused on resolving occurrences of Sonar rules squid:S1905 - Redundant casts should not be used. squid:S1068 - Unused private fields should be removed. squid:S1155 - Collection.isEmpty() should be used to test for emptiness. squid:S1854 - Dead stores should be removed. squid:CommentedOutCodeLine - Sections of code should not be "commented out". squid:S1118 - Utility classes should not have public constructors. You can find more information about the issue here: https://dev.eclipse.org/sonar/rules/show/squid:S1905 https://dev.eclipse.org/sonar/rules/show/squid:S1068 https://dev.eclipse.org/sonar/rules/show/squid:S1155 https://dev.eclipse.org/sonar/rules/show/squid:S1854 https://dev.eclipse.org/sonar/rules/show/squid:CommentedOutCodeLine https://dev.eclipse.org/sonar/rules/show/squid:S1118 Please let me know if you have any questions. George Kankava

thothbot commented 8 years ago

Thank you for your fixes