search

thothbot / parallax

Cross-platform Java 3D SDK
http://thothbot.github.io
MIT License
84 stars 26 forks source link

multiple code improvements: squid:CommentedOutCodeLine, squid:S1068, squid:UselessParenthesesCheck, squid:S00122, squid:S1192, squid:S1155 #87

Closed georgekankava closed 8 years ago

georgekankava commented 8 years ago

This pull request is focused on resolving occurrences of Sonar rules squid:CommentedOutCodeLine - Sections of code should not be "commented out". squid:S1068 - Unused private fields should be removed. squid:UselessParenthesesCheck - Useless parentheses around expressions should be removed to prevent any misunderstanding. squid:S00122 - Statements should be on separate lines. squid:S1192 - String literals should not be duplicated. squid:S1155 - Collection.isEmpty() should be used to test for emptiness. You can find more information about the issue here: https://dev.eclipse.org/sonar/rules/show/squid:CommentedOutCodeLine https://dev.eclipse.org/sonar/rules/show/squid:S1068 https://dev.eclipse.org/sonar/rules/show/squid:UselessParenthesesCheck https://dev.eclipse.org/sonar/rules/show/squid:S00122 https://dev.eclipse.org/sonar/rules/show/squid:S1192 https://dev.eclipse.org/sonar/rules/show/squid:S1155 Please let me know if you have any questions. George Kankava

thothbot commented 8 years ago

Thank you for your fix