search

thought-machine / pleasings

Addons & new build rules for Please
Apache License 2.0
98 stars 39 forks source link

Pleasings seems to be broken #110

Open mrsauravsahu opened 1 year ago

mrsauravsahu commented 1 year ago

I was using the master revision for pleasings in one of my projects (https://github.com/payobills/payobills/pull/42), everything was working fine but the latest merge to master seems to have broken things, rolling back to an older revision works. This is the error https://github.com/payobills/payobills/actions/runs/4211393374/jobs/7309708951

Downgrading Please from version 16.27.3 to 16.27.2
13:25:35.100   ERROR: ///shell//build_defs:shell failed:
Subrepo shell is not defined (referenced by //:all)
Build stopped after 390ms. 1 target failed:
    ///shell//build_defs:shell
Subrepo shell is not defined (referenced by //:all)
13:25:[35](https://github.com/payobills/payobills/actions/runs/4211393374/jobs/7309708951#step:7:36).154   ERROR: ///shell//build_defs:shell failed:
Subrepo shell is not defined (referenced by //:all)
Build stopped after 430ms. 1 target failed:
    ///shell//build_defs:shell
Subrepo shell is not defined (referenced by //:all)
clayrisser commented 1 year ago

I'm getting the same error.

mrsauravsahu commented 1 year ago

I'm using this revision until it it fixed @clayrisser

https://github.com/payobills/payobills/blob/9ff49576956d9c7bf9551cf27527e01a611251f0/BUILD#L3

github_repo(
  name = "pleasings",
  repo = "thought-machine/pleasings",
  revision = "6e554afd40449b5364d47f401bc22382f996733b",
)
Tatskaari commented 1 year ago

Pleasing are archived, and no longer maintained, in favour of plugins. We have moved the docker and kubernetes rules from there into plugins. What rules are you trying to use? We can change this ticket to be a feature request to make them plugins.

EDIT: turns out they're not :confused: I have a distinct memory or archiving them though. It's definitely meant to be archived so doing it now. Sorry about that confusion.