thought-machine / pleasings

Addons & new build rules for Please
Apache License 2.0
98 stars 39 forks source link

yarn_deps rule fails attempting to make a request but yarn install --offline works fine #92

Open err0r500 opened 2 years ago

err0r500 commented 2 years ago

Hello, I try to use the yarn_deps rule but when I do a plz run @pleasings//js/yarn_deps it fails with a :

Build stopped after 2.93s. 1 target failed:
    ///pleasings//js/yarn_deps:yarn_deps
Error building target ///pleasings//js/yarn_deps:yarn_deps: exit status 1
yarn install v1.22.17
[1/4] Resolving packages...
[2/4] Fetching packages...
error Can't make a request in offline mode ("https://registry.yarnpkg.com/ssri/-/ssri-6.0.2.tgz")
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this comman

However, I can do a yarn install --offline without problem...

Maybe it's because the yarn-offline-mirror path of the rule is used instead of my system ones (blind guess). I don't know how to solve this though (or I simply just don't get how it's supposed to be used)

Best,

err0r500 commented 2 years ago

Looks like I've got something working with the v1.0.0 (v1.10 & master throw the error above).

Also it takes the stdin as input so something like cat yarn.lock | plz run @pleasings//js/yarn_deps works

I think I'm too new to this to figure out this kind of subtleties easily