Fix for not working arrow rotations in expandablerecyclerview source

[l2dev]

So basically if you remove expandablerecyclerviewcheck project and in your sample project you try to rely on project expandablerecyclerview like this compile project(':expandablerecyclerview') then you will have a bad time. When expanding the groups, arrows are just rotating 360 degrees and events are messed up.

I digged deeper and saw that expandablerecyclerview project is relying on expandablerecyclerviewcheck project which in the gradle has a dependency on the repo compile 'com.thoughtbot:expandablerecyclerview:1.3'

After lots of trial and error I've concluded that the repo 'com.thoughtbot:expandablerecyclerview:1.3' has this issue fixed, while in provided source it's not fixed.

So here's what you need to do to fix this:

1. Go com/thoughtbot/expandablerecyclerview/ExpandCollapseController.java

Change:

boolean expanded = expandableList.expandedGroupIndexes[listPos.groupPos];

to:

boolean expanded = isGroupExpanded(listPos.groupPos);

2. Go com/thoughtbot/expandablerecyclerview/ExpandableRecyclerViewAdapter.java

Delete this block

       if (isGroupExpanded(group)) {    
          ((GVH) holder).expand();  
        } else {    
          ((GVH) holder).collapse();    
        }

Delete this block in onGroupExpanded Method

    //update header 
    int headerPosition = positionStart - 1; 
    notifyItemChanged(headerPosition);  

Delete this block in OnGroupCollapsed Metod

    //update header 
   int headerPosition = positionStart - 1;  
    notifyItemChanged(headerPosition);

3. Go com/thoughtbot/expandablerecyclerview/MultiTypeExpandableRecyclerViewAdapter.java

Delete block

      if (isGroupExpanded(group)) { 
        ((GVH) holder).expand();    
      } else {  
        ((GVH) holder).collapse();  
     }

4. Go com/thoughtbot/expandablerecyclerview/viewholders/GroupViewHolder.java

Replace this line:

listener.onGroupClick(getAdapterPosition());

With block:

      if (listener.onGroupClick(getAdapterPosition())) {
        collapse();
      } else {
        expand();
     }

[safeer-ahmed]

Its not working as expected by the changes you placed above.

[l2dev]

And is the animation arrow working when you are using just a library 'com.thoughtbot:expandablerecyclerview:1.3' ?

[safeer-ahmed]

Yes, animation is working but arrow issue is still there.

[nileshtrademonk]

Is there any prevention for arrow management.

[RiteshChandnani]

Going only with Point 4 fixes the arrow issue for me :)

[makazemi]

@eurbon : How to change Library? Its class are only readable.