thoughtspot / cs_tools

Scale your ThoughtSpot adoption with tools created by the ThoughtSpot Solutions Consulting organization.
https://thoughtspot.github.io/cs_tools/
Other
8 stars 6 forks source link

type "model' not supported in class TMLSupportedContent #157

Open jden98 opened 1 month ago

jden98 commented 1 month ago

First Stop

Platform Configuration

cs-tools-info-2024-07-18

Description

When I perform an export from an Org that has 'Models' as well as 'Worksheets', cs_tools scriptability errors stating KeyError: 'model'

Need to upload log files securely?

2024-07-18T21_50_04.log 2024-07-18T21_50_11.log 2024-07-18T21_56_07.log 2024-07-18T22_11_14.log 2024-07-18T22_12_58.log

boonhapus commented 1 month ago

Hey @jden98 , thanks for reporting this. It is blocked on merging https://github.com/thoughtspot/thoughtspot_tml/pull/22 , which I'll tackle next week

jden98 commented 1 month ago

Hi @boonhapus. I'm wondering if you were able to find any time to look into the PR you mentioned for adding Model support? Is there anything I can do to help move on this?

boonhapus commented 1 month ago

Hey @jden98 , I did some work on this today and got the PR merged. I need to add a few more tests and docs, then I'll push to pypi, so we can get the latest via CS Tools as well. I'll aim to finish this up tomorrow and will ping you here as well.

boonhapus commented 1 month ago

@jden98 can you try running cs_tools self sync (this will grab the latest thoughtspot_tml , which I just pushed) and then attempt your workflow again?

jden98 commented 1 month ago

As my workflow is using scriptability, when I call cs_tools tools scriptability export ... I still end up with a KeyError on the word 'model' with the traceback ending in cli\tools\scriptability\app.py:256 in scriptability_export. I'm assuming that even if the tml library is now able to support models, some additional work will be required for this export...?

boonhapus commented 1 month ago

Thanks @jden98 you're correct. We'll get this type properly supported and pushed to 1.5.10 this week!