search

thp / wavbreaker

Gtk3-based cross-platform GUI tool to losslessly split WAV, MP2 and MP3 files into multiple parts.
https://wavbreaker.sourceforge.io/
GNU General Public License v2.0
34 stars 10 forks source link

Cue files don't parse correctly #28

Closed justino closed 10 months ago

justino commented 11 months ago

Discovered a few issues with parsing cue files. The code currently requires cue files to be set up very specifically.

It's hard coded to expect the first line to be a FILE declaration, however the cue spec doesn't require this. Many cue files actually begin with a REM remark declaration.

It doesn't handle filenames, in the FILE declaration, that contain whitespace. This is a limitation of using the function sscanf to identify the FILE declaration line.

It's hard coded to expect the FILE declaration to end with WAVE. There are many other options available, the biggest one being MP3 which is a file type this application already supports.

justino commented 11 months ago

I have a fork that rips out the current parsing code and replaces it with libcue. I'll open up a PR very soon.

However, I'm unfamiliar with many if the build types this application supports: snap, flatpack, macos, win32. And am unsure about how to include this new dependency. I started to take a stab at it, haven't gotten far yet.

justino commented 10 months ago

This was closed by #29