search

thrau / jarchivelib

A simple archiving and compression library for Java
https://github.com/thrau/jarchivelib
Apache License 2.0
199 stars 36 forks source link

Preserve executability of files for tar archives #71

Open masc3d opened 6 years ago

masc3d commented 6 years ago

contributing to #23

thrau commented 5 years ago

it seems that this PR only covers one very specific case and introduces quite a lot of changes just to make that one case work. i think it would be more useful to take a more general approach to #23 using the Java 7 features.

masc3d commented 5 years ago

@thrau yes, it covers "only" the most common and relevant use case, as preserving executability is a key feature of eg tar archives.

there's not really many changes here, but you probably refer to fixing the inconsistent way factory has been handling CommonsArchiver This was necessary and should be merged anyhow as it's a potential generic defect.

imho best way forward would be to merge and do minor cleanup if necessary after #23 has been implemented.

masc3d commented 5 years ago

everything to make it work is essentially in specialized TarAchiver