search

threatstack / threatstack-ansible

Ansible for installing Threatstack Agent
https://www.threatstack.com
MIT License
23 stars 17 forks source link

Documentation improvements and task fixes #2

Closed jalaziz closed 9 years ago

jalaziz commented 9 years ago

The commit to remove the check for failed setup is required if we're not setting both the hostname and policy as the registered variable will be for the last (skipped) task and won't contain stderr.

The play will fail anyway since we're not ignoring errors, so non-zero result codes will result in the task failing.

If we really want to display a more friendly message, two solutions that come to mind are:

  1. Use different variables and check if each was skipped, and if not, what the result code or output was.
  2. Use one command with inline conditionals to include the appropriate options

In both cases, you'll want to add "ignore_errors: true" to the task(s).

jalaziz commented 9 years ago

Also, if you actually want the role name to be just threatstack instead of threatstack-ansible, you need to provide an alternative name to the role on galaxy.

jalaziz commented 9 years ago

@apollocatlin Any updates on this PR? I can also just use my fork, but would prefer to use the official role.

apollocatlin commented 9 years ago

Ah yes, sorry I will be updating in next 24.

jalaziz commented 9 years ago

No worries, if you want to change the role name, I can revert my changes to the documentation I've updated my PR to reflect the role name change.

apollocatlin commented 9 years ago

I fixed the naming outside of the pull request. https://galaxy.ansible.com/list#/roles/3018

Thank you for the pointer there. Getting the defaults in and changing the error checking now.

jalaziz commented 9 years ago

Thanks!

apollocatlin commented 9 years ago

fixing in https://github.com/threatstack/threatstack-ansible/pull/3

just due to some timing changes.